-
Notifications
You must be signed in to change notification settings - Fork 2.5k
v3.26.4 #7579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the v3.26.4 release changes and have some minor suggestions for improvement.
| - Optimize memory usage for image handling in webview (thanks @daniel-lxs!) | ||
| - Fix: Special tokens should not break task processing (#7539 by @pwilkin, PR by @pwilkin) | ||
| - Add Ollama API key support for Turbo mode (#7147 by @LivioGama, PR by @app/roomote) | ||
| - Rename Account tab to Cloud tab for clarity (thanks @app/roomote!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? I noticed the attribution format varies here:
- Lines 8-9 use:
(#ISSUE by @reporter, PR by @contributor) - Lines 10-11 use:
(thanks @contributor!)
According to the release.md guidelines, entries with linked issues should use the first format, while entries without issues should use the second. Could lines 10-11 be missing their issue references if they have any?
| - The image should feature a realistic-looking kangaroo doing something human-like that relates to the main highlight of the release | ||
| - Pass `releases/template.png` as the reference image for aspect ratio and kangaroo style | ||
| - Add the generated image to .changeset/v[version].md before the list of changes with format: `` | ||
| - Add the generated image to .changeset/v[version].md before the list of changes with format: `` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change to use absolute paths! Could we add a comment explaining why /releases/ is preferred over releases/? This would help future contributors understand that absolute paths ensure images render correctly regardless of the viewing context (e.g., GitHub, npm, local markdown viewers).
Important
Optimize memory usage, fix special tokens issue, add Ollama API key support, rename Account tab, and update documentation for image paths.
.roo/commands/release.md.CHANGELOG.md.This description was created by
for 20e9724. You can customize this summary. It will automatically update as commits are pushed.